Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36742: Corrects fix to handle decomposition in usernames #13812

Merged
merged 1 commit into from Jun 4, 2019
Merged

bpo-36742: Corrects fix to handle decomposition in usernames #13812

merged 1 commit into from Jun 4, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Jun 4, 2019 •
edited by bedevere-bot

@zooba zooba added the skip news label Jun 4, 2019
@zooba
Copy link
Member Author

zooba commented Jun 4, 2019

@ambv This is a security fix for a bug that hasn't been released yet - can we merge it before b1 and avoid having to create a new CVE?

@ambv ambv merged commit 8d0ef0b into python:master Jun 4, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jun 4, 2019

Thanks @zooba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 4, 2019

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot
Copy link

bedevere-bot commented Jun 4, 2019

GH-13813 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2019
@zooba @miss-islington
bpo-36742: Corrects fix to handle decomposition in usernames (pythonG…
e8bb3fe 
…H-13812)

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Jun 4, 2019

GH-13814 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Jun 4, 2019

Sorry, @zooba and @ambv, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8d0ef0b5edeae52960c7ed05ae8a12388324f87e 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2019
@zooba @miss-islington
bpo-36742: Corrects fix to handle decomposition in usernames (pythonG…
f8dc76f 
…H-13812)

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Jun 4, 2019

GH-13815 is a backport of this pull request to the 2.7 branch.

miss-islington added a commit that referenced this pull request Jun 4, 2019
@miss-islington @zooba
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812)
250b62a 
(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Jun 4, 2019
@zooba
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812)
f61599b
@zooba zooba deleted the bpo-36742 branch Jun 4, 2019
ned-deily pushed a commit that referenced this pull request Jun 4, 2019
@miss-islington @zooba @ned-deily
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812)…
fd1771d 
… (GH-13814)

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower <steve.dower@python.org>
larryhastings pushed a commit that referenced this pull request Sep 7, 2019
@vstinner @larryhastings
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812)…
095373c 
… (GH-13814) (#14772)

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower <steve.dower@python.org>
(cherry picked from commit fd1771d)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@zooba @DinoV
bpo-36742: Corrects fix to handle decomposition in usernames (python#…
bbb1e39 
…13812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

@zooba zooba

Labels
skip news type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zooba @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni