Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99845: Change _PyDict_KeysSize() return type to size_t #99848

Merged
merged 2 commits into from Nov 29, 2022
Merged

gh-99845: Change _PyDict_KeysSize() return type to size_t #99848

merged 2 commits into from Nov 29, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 28, 2022 •
edited by bedevere-bot

  • Change _PyDict_KeysSize() and shared_keys_usable_size() return type from signed (Py_ssize_t) to unsigned (size_t) type.
  • new_values() argument type is now unsigned (size_t).
  • init_inline_values() now uses size_t rather than int for the 'i' iterator variable.
  • type.sizeof() implementation now uses unsigned (size_t) type.

@bedevere-bot bedevere-bot mentioned this pull request Nov 28, 2022
Closed
@vstinner
gh-99845: Change _PyDict_KeysSize() return type to size_t
b8953e1 
* Change _PyDict_KeysSize() and shared_keys_usable_size() return type
  from signed (Py_ssize_t) to unsigned (size_t) type.
* new_values() argument type is now unsigned (size_t).
* init_inline_values() now uses size_t rather than int for the 'i'
  iterator variable.
* type.__sizeof__() implementation now uses unsigned (size_t) type.
@vstinner
Copy link
Member Author

vstinner commented Nov 28, 2022

cc @methane

@vstinner
Copy link
Member Author

vstinner commented Nov 28, 2022

I would prefer to change _PyDict_SizeOf() return type to size_t, but it's not required to fix issue #99845, and it can impact the 3rd party frozendict project which uses it.

@vstinner
Copy link
Member Author

vstinner commented Nov 28, 2022

I would prefer to change _PyDict_SizeOf() return type to size_t, but it's not required to fix issue #99845, and it can impact the 3rd party frozendict project which uses it.

Another more radical change is to move the private function to internal C API, and frozendict should call dict.__sizeof__() method instead.

methane
methane approved these changes Nov 29, 2022
View changes
Copy link
Member

@methane methane left a comment

The patch looks good to me.

Is Py_ssize_t recommended for container size and size_t recommended for memory size for now?

@vstinner vstinner merged commit 4246fe9 into python:main Nov 29, 2022
13 checks passed
@vstinner vstinner deleted the dict_sizeof branch Nov 29, 2022
@vstinner
Copy link
Member Author

vstinner commented Nov 29, 2022

I was confused by assert(size > 0); is new_values(). I read it as assert(size >= 0);, to reject negative values. So I replaced it with: assert(size >= 1); which is less confusing for me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

@markshannon markshannon

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @methane @bedevere-bot