Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91291: Accept attributes as keyword arguments in decimal.localcontext #32242

Merged
merged 20 commits into from Apr 22, 2022
Merged

gh-91291: Accept attributes as keyword arguments in decimal.localcontext #32242

merged 20 commits into from Apr 22, 2022

Conversation

dignissimus
Copy link
Contributor

@dignissimus dignissimus commented Apr 1, 2022 •
edited by JelleZijlstra

This allows attributes to be set like this

with decimal.localcontext(prec=10):
    ...

instead of like this

with decimal.localcontext() as ctx:
    ctx.prec = 10
    ...

#91291

https://bugs.python.org/issue47135

@dignissimus dignissimus requested a review from rhettinger as a code owner Apr 1, 2022
JelleZijlstra
JelleZijlstra reviewed Apr 4, 2022
View changes
Lib/_pydecimal.py Outdated Show resolved Hide resolved
Lib/test/test_decimal.py Show resolved Hide resolved
Doc/library/decimal.rst Show resolved Hide resolved
Modules/_decimal/_decimal.c Outdated Show resolved Hide resolved
@dignissimus
Copy link
Contributor Author

dignissimus commented Apr 4, 2022

Thank you for the review, I'll be able to make the changes later today

JelleZijlstra
JelleZijlstra reviewed Apr 4, 2022
View changes
Doc/library/decimal.rst Outdated Show resolved Hide resolved
Lib/_pydecimal.py Outdated Show resolved Hide resolved
Lib/_pydecimal.py Outdated Show resolved Hide resolved
dignissimus and others added 4 commits Apr 4, 2022
@dignissimus @JelleZijlstra
Use frozen set to store context attributes
32c5ae0 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@dignissimus @JelleZijlstra
Correctly check whether context attributes are valid
12acb22 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@dignissimus
Update decimal.rst
0a1a624
@dignissimus
Update decimal.rst
88862ac
@dignissimus dignissimus requested a review from JelleZijlstra Apr 13, 2022
JelleZijlstra
JelleZijlstra approved these changes Apr 14, 2022
View changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Looks good apart from one nit which I'll apply myself. Then I'll also run this through the buildbots in case there's a refleak.

Modules/_decimal/_decimal.c Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra changed the title bpo-47135: Accept attributes as keyword arguments in decimal.localcontext gh-91291: Accept attributes as keyword arguments in decimal.localcontext Apr 14, 2022
@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 14, 2022
@bedevere-bot
Copy link

bedevere-bot commented Apr 14, 2022

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit df3ab57 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 14, 2022
TeamSpen210
TeamSpen210 reviewed Apr 14, 2022
View changes
Lib/_pydecimal.py Show resolved Hide resolved
JelleZijlstra
JelleZijlstra reviewed Apr 14, 2022
View changes
Lib/_pydecimal.py Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra self-assigned this Apr 21, 2022
@JelleZijlstra JelleZijlstra merged commit bcf14ae into python:main Apr 22, 2022
13 checks passed
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 22, 2022
Closed
@penguin-wwy penguin-wwy mentioned this pull request Apr 22, 2022
Open
@vstinner
Copy link
Member

vstinner commented Apr 22, 2022

It seems like this change caused a regression: #91821

@dignissimus
Copy link
Contributor Author

dignissimus commented Apr 22, 2022

Oh, interesting. I'll try and work out where the issue is.

JelleZijlstra added a commit to python/typeshed that referenced this pull request Apr 26, 2022
@JelleZijlstra
decimal: kwargs to localcontext()
af31b21 
python/cpython#32242
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@TeamSpen210 TeamSpen210

@rhettinger rhettinger

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dignissimus @bedevere-bot @vstinner @JelleZijlstra @TeamSpen210 @the-knights-who-say-ni