Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sys.getdxp() and Tools/scripts/analyze_dxp.py: superceded by Py_STATS infra #97670

Closed
vstinner opened this issue Sep 30, 2022 · 2 comments
Closed

Remove sys.getdxp() and Tools/scripts/analyze_dxp.py: superceded by Py_STATS infra #97670

vstinner opened this issue Sep 30, 2022 · 2 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

vstinner commented Sep 30, 2022

In Python 3.10/3.11, the old DYNAMIC_EXECUTION_PROFILE and DXPAIRS macros were replaced with Py_STATS macro. The sys.getdxp() function is no longer used with Tools/scripts/analyze_dxp.py. Now if Python is built with ./configure --enable-pystats, statistics on opcodes are written into the /tmp/py_stats/ directory and these files can be analyzed with Tools/scripts/summarize_stats.py.

I propose to remove sys.getdxp() and Tools/scripts/analyze_dxp.py.
@vstinner vstinner added the type-bug An unexpected behavior, bug, or error label Sep 30, 2022
@bedevere-bot bedevere-bot mentioned this issue Sep 30, 2022
Merged
@vstinner vstinner mentioned this issue Sep 30, 2022
Closed
@mdboom
Copy link
Contributor

mdboom commented Sep 30, 2022

Cc: @markshannon

vstinner added a commit that referenced this issue Oct 4, 2022
@vstinner
gh-97670: Remove sys.getdxp() and analyze_dxp.py script (#97671)
116fa62 
Remove the sys.getdxp() function and the Tools/scripts/analyze_dxp.py
script. DXP stands for "dynamic execution pairs". They were related
to DYNAMIC_EXECUTION_PROFILE and DXPAIRS macros which have been
removed in Python 3.11. Python can now be built with "./configure
--enable-pystats" to gather statistics on Python opcodes.
@vstinner
Copy link
Member Author

vstinner commented Oct 17, 2022

Fixed by 116fa62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdboom @vstinner