Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite run_parser* functions to always return a mod_ty #17

Merged
merged 6 commits into from Mar 24, 2020
Merged

Rewrite run_parser* functions to always return a mod_ty #17

merged 6 commits into from Mar 24, 2020

Conversation

lysnikolaou
Copy link

@lysnikolaou lysnikolaou commented Mar 23, 2020 •
edited

Closes #15.

lysnikolaou added 3 commits Mar 23, 2020
@lysnikolaou
Rewrite run_parser* functions to always return a mod_ty
128f5fb 
    * The caller is responsible for transforming the mod_ty to
      a code object or an AST object
@lysnikolaou
Merge branch 'pegen' into rewrite-run-parser
292597b
@lysnikolaou
Run clang-format
85e6adf
gvanrossum
gvanrossum reviewed Mar 23, 2020
View changes
Copy link

@gvanrossum gvanrossum left a comment

I still think we should switch EXTENSION_SUFFIX to be much smaller and move most of that code to a separate file.

Python/pythonrun.c Outdated Show resolved Hide resolved
Parser/pegen/peg_api.c Outdated Show resolved Hide resolved
Parser/pegen/peg_api.c Outdated Show resolved Hide resolved
Parser/pegen/peg_api.c Outdated Show resolved Hide resolved
Parser/pegen/pegen.c Show resolved Hide resolved
@lysnikolaou
Copy link
Author

lysnikolaou commented Mar 23, 2020 •
edited by gvanrossum

I still think we should switch EXTENSION_SUFFIX to be much smaller and move most of that code to a separate file.

I have this almost ready and was thinking of opening a new PR for it. What do you think?

Okay, a separate PR is fine!

gvanrossum
gvanrossum reviewed Mar 23, 2020
View changes
Copy link

@gvanrossum gvanrossum left a comment

Better, but I'd still like to see if we can easily drop the filename_ob parameters.

@lysnikolaou
Copy link
Author

lysnikolaou commented Mar 23, 2020

Better, but I'd still like to see if we can easily drop the filename_ob parameters.

Just pushed a fix for this.

gvanrossum
gvanrossum approved these changes Mar 24, 2020
View changes
Copy link

@gvanrossum gvanrossum left a comment

Bang!

@lysnikolaou
Copy link
Author

lysnikolaou commented Mar 24, 2020

Bang!

Yes!

@lysnikolaou lysnikolaou merged commit 14ae717 into pegen Mar 24, 2020
@lysnikolaou lysnikolaou deleted the rewrite-run-parser branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite of run_parser* functions
3 participants
@lysnikolaou @gvanrossum @pablogsal