Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query-classification-and-display.md #11736

Merged
merged 2 commits into from Dec 19, 2022
Merged

Update query-classification-and-display.md #11736

merged 2 commits into from Dec 19, 2022

Conversation

jf205
Copy link
Contributor

@jf205 jf205 commented Dec 19, 2022

Removes the section about queries run on LGTM.com.

Removes the section about queries run on LGTM.com.
Precision: | very-high | high | medium | low
---------------|-----------|---------|---------|----
Error | **Yes** | **Yes** | **Yes** | No
Warning | **Yes** | **Yes** | **Yes** | No
Copy link
Contributor

@aibaars aibaars Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we simply delete this entire file? The Attributable Queries is obsolete too, and the and display bit in the title is only relevant to LGTM. Alternatively, you could of course rewrite this entire file to make it relevant to the way the default code-scanning suites work.

@jf205
Copy link
Contributor Author

jf205 commented Dec 19, 2022

Yes, I think you're right @aibaars. Let's delete the entire file 🔥

@jf205 jf205 merged commit 55a04e7 into main Dec 19, 2022
4 checks passed
@jf205 jf205 deleted the jf205-patch-1 branch Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants