Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix UB in overflow checks #45882

Merged
merged 1 commit into from Dec 20, 2022
Merged

src: fix UB in overflow checks #45882

merged 1 commit into from Dec 20, 2022
+4 −3

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Dec 16, 2022

Refs: #45868

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Dec 16, 2022
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2022
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 16, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48514/

@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 16, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48521/

This was referenced Dec 17, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48597/

@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48633/

@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48654/

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5124613 into nodejs:main Dec 20, 2022
52 checks passed
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 20, 2022

Landed in 5124613

@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@santigimeno santigimeno

@cjihrig cjihrig

@VoltrexKeyva VoltrexKeyva

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bnoordhuis @nodejs-github-bot @jasnell @addaleax @santigimeno @cjihrig @VoltrexKeyva