New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating deprecations.js file to be more straightforward #1581
Conversation
|
| Name | Type |
|---|---|
| @primer/css | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
After looking at the code, I think the original intent was you could mark something to be deprecated such that you want it deprecated at a specific later version but not right now. I don't believe we ever really utilized this though. |
|
Love this direction! Is there a reason we couldn't make this a JSON file? With JSON, we could use JSON schema to validate the structure. |
This updates the deprecations.js file and process a bit simpler. I modeled this after the work @colebemis did in primer/primitives#202
The placement of the deprecated file hasn't changed but the structure has. The output
dist/deprecations.jsonfile is as follows: And documented here https://primer-css-82rx1coiw-primer.vercel.app/css/tools/deprecations{ "selectors": {...}, "variables": {...}, "mixins": {...} }Deprecated Selectors
These are deprecated selectors and should not be used. They include a replacement value, which can be an array or null.
<-- Replace with this selector.<-- Replace with one of these selectors.<-- No option available, remove selector.