New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable searching for assemblies in GAC_Arm64 on Windows #17816
Conversation
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
…text.cs Co-authored-by: Ilya <darpa@yandex.ru>
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/CoreCLR/CorePsAssemblyLoadContext.cs
Outdated
Show resolved
Hide resolved
other code cleanup since I'm making slightly bigger change
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
Handy links: |
PR Summary
The code to enable searching the GAC was limited to GAC_32 and GAC_64 which fails on Windows Arm64 systems. Fix is to use GAC_Arm64 if pwsh is running as a Arm64 process.
Manually validated with PKI module with (requires admin):
PR Context
Fix #17814
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).