New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove potential ANSI escape sequences in strings before using in Out-GridView
#17664
Conversation
src/Microsoft.Management.UI.Internal/commandHelpers/OutGridView.cs
Outdated
Show resolved
Hide resolved
…w.cs Co-authored-by: Ilya <darpa@yandex.ru>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
Handy links: |
PR Summary
Out-GridViewspecifically uses the formatted output so that it resembles what you'd see inFormat-Table. This means that any ANSI that is included would be in the strings inOut-GridVieweven though WPF doesn't know how to render them.The fix is as objects are being sent to
Out-GridView, we use theStringDecoratedclass to remove known ANSI escape sequences so they are just plaintext.PR Context
Fix #17636
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).