Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow commands to still be executed even if the current working directory no longer exists #17579

Merged
merged 4 commits into from Aug 2, 2022
Merged

Allow commands to still be executed even if the current working directory no longer exists #17579

merged 4 commits into from Aug 2, 2022

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jun 24, 2022 •
edited

PR Summary

In the case where the current working directory is deleted, there are two places in the code that fail. The CommandSearcher tries to search the current directory and an exception is thrown. The change is to catch that exception and have the logic continue where current directory is null which is already handled. After this, the NativeCommandProcessor always tries to set the native command process working directory to the current working directory which will fail and an exception is thrown. So if the current working directory doesn't exist, don't set that property. The default for this member is already an empty string.

This change makes pwsh work the same as bash.

PR Context

Fix #2116

PR Checklist

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jun 24, 2022

Working on tests

@SteveL-MSFT SteveL-MSFT changed the title WIP: Allow commands to still be executed even if the current working directory no longer exists Allow commands to still be executed even if the current working directory no longer exists Jun 25, 2022
@SteveL-MSFT SteveL-MSFT added the WG-Engine core PowerShell engine, interpreter, and runtime label Jun 25, 2022
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jun 25, 2022

@PowerShell/wg-powershell-engine should review if there's any concerns on side effects of this change

iSazonov
iSazonov approved these changes Jun 25, 2022
View changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Formally LGTM but with 3 minor comments.

src/System.Management.Automation/engine/NativeCommandProcessor.cs Outdated Show resolved Hide resolved
src/System.Management.Automation/engine/CommandPathSearch.cs Show resolved Hide resolved
@daxian-dbw daxian-dbw closed this Jun 28, 2022
@daxian-dbw daxian-dbw reopened this Jun 28, 2022
@daxian-dbw
Copy link
Member

daxian-dbw commented Jun 28, 2022

Reopen PR to re-trigger the CI runs.

@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Jul 6, 2022
@msftbot
Copy link

msftbot bot commented Jul 6, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@msftbot msftbot bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Jul 25, 2022
@msftbot msftbot bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 1, 2022
daxian-dbw
daxian-dbw approved these changes Aug 1, 2022
View changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

LGTM

@SteveL-MSFT SteveL-MSFT assigned daxian-dbw and unassigned TravisEz13 Aug 1, 2022
@pull-request-quantifier
Copy link

pull-request-quantifier bot commented Aug 1, 2022

This PR has 43 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +40 -3
Percentile : 17.2%

Total files changed: 4

Change summary by file extension:
.cs : +9 -3
.ps1 : +31 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit 9213b77 into PowerShell:master Aug 2, 2022
39 checks passed
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 2, 2022
@SteveL-MSFT SteveL-MSFT deleted the cwd branch Aug 2, 2022
@msftbot
Copy link

msftbot bot commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.🎉

Handy links:

@msftbot msftbot bot mentioned this pull request Aug 12, 2022
Closed
@SteveL-MSFT SteveL-MSFT mentioned this pull request Sep 26, 2022
Closed
5 tasks
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov

@daxian-dbw daxian-dbw

@adityapatwardhan adityapatwardhan

Assignees

@daxian-dbw daxian-dbw

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small WG-Engine core PowerShell engine, interpreter, and runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External commands fail if delete the powershell invoked directory
4 participants
@SteveL-MSFT @daxian-dbw @iSazonov @TravisEz13