Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticode https fix issue #12827 #16134

Merged

Conversation

Ryan-Hutchison-USAF
Copy link
Contributor

@Ryan-Hutchison-USAF Ryan-Hutchison-USAF commented Sep 22, 2021

PR Summary

A fix for issue #12827

PR Context

The Set-AuthenticodeSignature command only allows the use of an http timestamp server only. I added https:// as also a valid prefix.

PR Checklist

@iSazonov iSazonov requested review from PaulHigin and TravisEz13 Sep 22, 2021
@PaulHigin PaulHigin added WG-Security Needs-Triage labels Sep 22, 2021
@microsoft-cla
Copy link

microsoft-cla bot commented Sep 22, 2021

CLA assistant check
All CLA requirements met.

@Ryan-Hutchison-USAF Ryan-Hutchison-USAF marked this pull request as ready for review Sep 22, 2021
@msftbot msftbot bot added the Review - Needed label Sep 30, 2021
@msftbot
Copy link

msftbot bot commented Sep 30, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Copy link
Member

@TravisEz13 TravisEz13 left a comment

see comments

@msftbot msftbot bot added Waiting on Author and removed Review - Needed labels Oct 3, 2021
I agree.

Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
@msftbot msftbot bot removed the Waiting on Author label Oct 4, 2021
@msftbot msftbot bot added the Review - Needed label Oct 12, 2021
@msftbot
Copy link

msftbot bot commented Oct 12, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@PaulHigin
Copy link
Collaborator

PaulHigin commented Nov 15, 2021

@Ryan-Hutchison-USAF Can you please make the change requested by @TravisEz13?

@msftbot msftbot bot removed the Review - Needed label Nov 15, 2021
@PaulHigin PaulHigin removed the Needs-Triage label Nov 15, 2021
@msftbot msftbot bot added the Review - Needed label Nov 23, 2021
@msftbot
Copy link

msftbot bot commented Nov 23, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov closed this Jul 26, 2022
@iSazonov iSazonov reopened this Jul 26, 2022
@msftbot msftbot bot removed the Review - Needed label Jul 26, 2022
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 26, 2022

@TravisEz13 Please update your review.

@TravisEz13 TravisEz13 merged commit f2204a0 into PowerShell:master Aug 1, 2022
48 checks passed
@iSazonov iSazonov added the CL-General label Aug 1, 2022
@msftbot
Copy link

msftbot bot commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General WG-Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants