Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up bindir for new version of goreleaser #6621

Merged
merged 1 commit into from Nov 15, 2022
Merged

Fix up bindir for new version of goreleaser #6621

merged 1 commit into from Nov 15, 2022
+1 −1

Conversation

samcoe
Copy link
Member

@samcoe samcoe commented Nov 15, 2022 •
edited

Fixes regression caused by updating goreleaser where NFPM used to work differently goreleaser/goreleaser#2476.

Closes #6619

@samcoe samcoe self-assigned this Nov 15, 2022
@samcoe samcoe requested a review from a team as a code owner Nov 15, 2022
@samcoe samcoe requested review from vilmibm (assigned from cli/code-reviewers) and removed request for a team Nov 15, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Nov 15, 2022
@samcoe samcoe merged commit 649fb35 into trunk Nov 15, 2022
9 checks passed
The GitHub CLI automation moved this from Needs review 🤔 to Pending Release 🥚 Nov 15, 2022
@samcoe samcoe deleted the fix-nfpms-goreleaser branch Nov 15, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Nov 15, 2022
@mislav
Copy link
Member

mislav commented Nov 15, 2022

Thanks for the fast fix. This isn't the first time this has happened either: #4025

Hopefully it will be the last :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm

Assignees

@samcoe samcoe

Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bash: gh: command not found (gh binary is installed in the wrong path)
2 participants
@samcoe @mislav