Skip to content

Data flow: Add consistency checks for parameter positions#11564

Merged
hvitved merged 4 commits intogithub:mainfrom
hvitved:dataflow/parameter-position-consistency-checks
Dec 6, 2022
Merged

Data flow: Add consistency checks for parameter positions#11564
hvitved merged 4 commits intogithub:mainfrom
hvitved:dataflow/parameter-position-consistency-checks

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Dec 5, 2022

Adds two new consistency checks:

  • No two parameters (in the same callable) with overlapping parameter positions, and
  • No parameters with multiple parameter positions.

@hvitved hvitved force-pushed the dataflow/parameter-position-consistency-checks branch from b660911 to 7972db6 Compare December 5, 2022 16:07
@hvitved hvitved marked this pull request as ready for review December 5, 2022 18:39
@hvitved hvitved requested review from a team as code owners December 5, 2022 18:39
@hvitved
Copy link
Contributor Author

hvitved commented Dec 5, 2022

@MathiasVP : Note that one of the consistency checks fails for C++.

Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvitved hvitved merged commit b5e2e1e into github:main Dec 6, 2022
@hvitved hvitved deleted the dataflow/parameter-position-consistency-checks branch December 6, 2022 08:33
@MathiasVP
Copy link
Contributor

@MathiasVP : Note that one of the consistency checks fails for C++.

Thanks for the heads up 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants