Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

1. If you don't have an account on b.p.o, please create one
2. Make sure your GitHub username is listed in "Your Details" at b.p.o
3. If you have not already done so, please sign the PSF contributor agreement
4. If you just signed the CLA, please wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@paulschreiber: please sign the CLA.

Codecov Report

Merging #55 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
- Hits       289097   289095       -2     
- Misses      61851    61853       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a97d8...53d64b9. Read the comment docs.

I'm paulschreiber on bugs.python.org. I signed the CLA.

@paulschreiber If you haven't put your GitHub user name in your bugs.python.org account, you will need to do that. If you have, then you should be good 👍

It also takes one US business day for the CLA to get updated by a human being, so hopefully this will get cleared up sometime today or tomorrow (and I checked that the GitHub username is filled in properly on bpo).

@paulschreiber would you resolve conflict?

thanks

I think this needs to be backported to 3.6, 3.5, and 2.7.
I'm now getting conflict while cherry-picking my commit from GH-283.
Is it ok if I cherrypick this into 3.6, 3.5, and 2.7?
Thanks.

Go ahead, I think it's OK to cherry-pick to those releases, certainly for 3.6.

Thanks @paulschreiber for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Sorry, @paulschreiber and @methane, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.