This is almost exactly the same as I used for the PEP - I just removed the "with X sub-exceptions" line from the tracebacks because I think it clutters them and is not very useful.

This is almost exactly the same as I used for the PEP - I just removed the "with X sub-exceptions" line from the tracebacks because I think it clutters them and is not very useful.

Just be sure to update the PEP examples. :-)

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2052c77 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

I looked more at the C parts of the PR, great stuff.

Do you have an opinion on whether it's better to box all EG tracebacks or only the nested ones?

Do you have an opinion on whether it's better to box all EG tracebacks or only the nested ones?

I think it's OK to always box the EGs because they're pretty special, although I'd change the very first line of the output, from:

    | Traceback (most recent call last):
    |   File "{__file__}", line {exc.__code__.co_firstlineno + 9}, in exc
    |     raise EG("eg", [VE(1), exc, VE(4)])
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | ExceptionGroup: eg
    +-+---------------- context.1 ----------------
        | ValueError: 1
        +---------------- context.2 ----------------
        | Traceback (most recent call last):
        |   File "{__file__}", line {exc.__code__.co_firstlineno + 6}, in exc
        |     raise EG("nested", [TE(2), TE(3)])
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        | ExceptionGroup: nested
        +-+---------------- context.2.1 ----------------
        | TypeError: 2
        +---------------- context.2.2 ----------------
        | TypeError: 3
        +------------------------------------
        +---------------- context.3 ----------------
        | ValueError: 4
        +------------------------------------

to:

    + Exception group traceback (most recent call last):
    |
    |   File "{__file__}", line {exc.__code__.co_firstlineno + 9}, in exc
    |     raise EG("eg", [VE(1), exc, VE(4)])
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | ExceptionGroup: eg
    +-+---------------- context.1 ----------------
        | ValueError: 1
        +---------------- context.2 ----------------
        | Traceback (most recent call last):
        |   File "{__file__}", line {exc.__code__.co_firstlineno + 6}, in exc
        |     raise EG("nested", [TE(2), TE(3)])
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        | ExceptionGroup: nested
        +-+---------------- context.2.1 ----------------
        | TypeError: 2
        +---------------- context.2.2 ----------------
        | TypeError: 3
        +------------------------------------
        +---------------- context.3 ----------------
        | ValueError: 4
        +------------------------------------

@1st1 - see below.

    + Exception group traceback (most recent call last):
    |
    |   File "{__file__}", line {exc.__code__.co_firstlineno + 9}, in exc
    |     raise EG("eg", [VE(1), exc, VE(4)])
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | ExceptionGroup: eg
    +-+---------------- context.1 ----------------
        | ValueError: 1
        +---------------- context.2 ----------------
        | Traceback (most recent call last):
        |   File "{__file__}", line {exc.__code__.co_firstlineno + 6}, in exc
        |     raise EG("nested", [TE(2), TE(3)])
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        | ExceptionGroup: nested
        +-+---------------- context.2.1 ----------------

The indentation of the next line is wrong. Is this a copy-paste error or a bug?

    | TypeError: 2
    +---------------- context.2.2 ----------------
    | TypeError: 3
    +------------------------------------
    +---------------- context.3 ----------------
    | ValueError: 4
    +------------------------------------

The indentation of the next line is wrong. Is this a copy-paste error or a bug?

Copy/paste/whitespace issue; no implementation bugs were observed!

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 61fab3f 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

LG!

Thank you!

@gpshead @erlend-aasland @1st1 I'll wait a bit before merging in case you want to have another look.

@erlend-aasland I agree with your comment. I tried using gotos but it was a bit delicate because you need to make sure the refcounting is still correct. This is a refactor that should be done in its own PR and not together with major functional changes. The current method preserves the control flow so it doesn't impact refcounts.

This is a refactor that should be done in its own PR and not together with major functional changes.

+1 🙂

Thank you everyone for your help!