Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: model ActiveSupport json_escape flow #11417

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ruby: model ActiveSupport json_escape flow #11417

wants to merge 2 commits into from
+33 −0

Conversation

alexrford
Copy link
Contributor

@alexrford alexrford commented Nov 24, 2022 •
edited

Adds taint flow from arg to return value. This is not a general purpose sanitizer for XSS https://api.rubyonrails.org/v7.0.4/classes/ERB/Util.html#method-c-json_escape

@alexrford alexrford changed the title Ruby: model ActiveSupport =json_escape flow Ruby: model ActiveSupport json_escape flow Nov 24, 2022
@github-actions github-actions bot added the Ruby label Nov 24, 2022
@alexrford alexrford added the no-change-note-required This PR does not need a change note label Nov 24, 2022
@alexrford alexrford marked this pull request as ready for review Nov 24, 2022
@alexrford alexrford requested a review from a team as a code owner Nov 24, 2022
hmac
hmac approved these changes Nov 24, 2022
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmac hmac

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexrford @hmac