C#: ExternalFlow.qll cleanup. #11395
Open
+7
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33b05f9
to
311614c
Compare
… longer inlined in the code.
|
Will trigger DCA to see, if we experience any performance issues by untying the SCC knot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In this PR we delete the bi-directional import of
ExternalFlowthat was needed to include all models defined in framework specific files.It turned out that some other parts of the code replied on the SCC that was generated from the bi-directional import. Most cases where fixed on #10777 and this PR fixes the remaining one and deletes all the un-needed import code.