Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93649: Split float/long tests from _testcapimodule.c #99549

Merged
merged 3 commits into from Nov 17, 2022
Merged

gh-93649: Split float/long tests from _testcapimodule.c #99549

merged 3 commits into from Nov 17, 2022
+677 −625

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 16, 2022 •
edited by miss-islington

Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland erlend-aasland requested a review from a team as a code owner Nov 16, 2022
@erlend-aasland erlend-aasland requested a review from vstinner Nov 16, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 16, 2022
Open
vstinner
vstinner approved these changes Nov 16, 2022
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 16, 2022

Thanks for the review!

@erlend-aasland erlend-aasland added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 16, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Nov 16, 2022

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

miss-islington commented Nov 17, 2022

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor

miss-islington commented Nov 17, 2022

Sorry, I can't merge this PR. Reason: 5 of 7 required status checks are expected..

@miss-islington
Copy link
Contributor

miss-islington commented Nov 17, 2022

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 12b5a3c into python:main Nov 17, 2022
13 checks passed
@erlend-aasland erlend-aasland deleted the split-testcapi/numbers branch Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@python/windows-team windows-team

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlend-aasland @miss-islington @vstinner @bedevere-bot