Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-90699: disallow _Py_IDENTIFIER in core code #99210

Merged
merged 3 commits into from Nov 9, 2022
Merged

GH-90699: disallow _Py_IDENTIFIER in core code #99210

merged 3 commits into from Nov 9, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 7, 2022 •
edited by miss-islington

Automerge-Triggered-By: GH:ericsnowcurrently

@bedevere-bot bedevere-bot mentioned this pull request Nov 7, 2022
Closed
@kumaraditya303 kumaraditya303 marked this pull request as ready for review Nov 8, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Nov 9, 2022
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM

@ericsnowcurrently ericsnowcurrently added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 9, 2022
@miss-islington miss-islington merged commit 6e3cc72 into python:main Nov 9, 2022
13 checks passed
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 9, 2022

Thanks for working on this, @kumaraditya303!

@kumaraditya303 kumaraditya303 deleted the disable-id branch Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumaraditya303 @ericsnowcurrently @bedevere-bot @miss-islington