Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audit events for thread creation/close #99377

Open
zooba opened this issue Nov 11, 2022 · 0 comments
Open

Add audit events for thread creation/close #99377

zooba opened this issue Nov 11, 2022 · 0 comments
Assignees
@zooba
Labels
3.10 3.11 3.12

Comments

@zooba
Copy link
Member

zooba commented Nov 11, 2022 •
edited by bedevere-bot

We already have events for interpreter creation and free, but not threads.
@zooba zooba self-assigned this Nov 11, 2022
zooba added a commit to zooba/cpython that referenced this issue Nov 11, 2022
@zooba
pythongh-99377: Add audit events for thread creation and clear
5c53261
@bedevere-bot bedevere-bot mentioned this issue Nov 11, 2022
Merged
zooba added a commit that referenced this issue Nov 16, 2022
@zooba
gh-99377: Add audit events for thread creation and clear (GH-99378)
19c1462
zooba added a commit to zooba/cpython that referenced this issue Nov 16, 2022
@zooba
pythongh-99377: Prevent raising audit event when thread state has not…
c732ecc 
… actually been set.

This can occur during initialization. Without the check, later calls to get the interpreter state will cause a fatal error.
@bedevere-bot bedevere-bot mentioned this issue Nov 16, 2022
Merged
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this issue Nov 16, 2022
@ericsnowcurrently
Revert "pythongh-99377: Add audit events for thread creation and clear (
528dee0 
pythonGH-99378)"

This reverts commit 19c1462.
@bedevere-bot bedevere-bot mentioned this issue Nov 16, 2022
Closed
zooba added a commit that referenced this issue Nov 17, 2022
@zooba
gh-99377: Revert audit events for thread state creation and free, bec…
5fdd49d 
…ause the GIL is not properly held at these times (GH-99543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
3.10 3.11 3.12
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zooba