Improve Scrollbar drag behavior #112434
Merged
Improve Scrollbar drag behavior #112434
+97
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xu-baolin
commented
Sep 27, 2022
| @@ -1446,15 +1457,15 @@ class RawScrollbar extends StatefulWidget { | |||
| /// Provides defaults gestures for dragging the scrollbar thumb and tapping on the | |||
| /// scrollbar track. | |||
| class RawScrollbarState<T extends RawScrollbar> extends State<T> with TickerProviderStateMixin<T> { | |||
| Offset? _dragScrollbarAxisOffset; | |||
| Offset? _startDragScrollbarAxisOffset; | |||
There was a problem hiding this comment.
@TahaTesser Thanks for the sync info, I tested it and it did fix the issue by accident. : )
There was a problem hiding this comment.
@Piinks Hi, do you have a chance to take a look at this change? : )
There was a problem hiding this comment.
Ah yes, apologies! I was out of town and this got buried in my inbox. I checked it out before I left and forgot to click submit - sorry!
Piinks
reviewed
Oct 3, 2022
Thank you, this maybe also help to implement the infinite scrollbar. You know that the infinite scrollable's scroll extent always changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This change lets the thumb always follow the pointer even if the scroll extent changed when dragging the thumb.
Fixes #112072
Fixes #107765