Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Older version of get_write_buffer_limits overwrites the new implementation #99277

Closed
csuriano23 opened this issue Nov 9, 2022 · 0 comments
Closed

Older version of get_write_buffer_limits overwrites the new implementation #99277

csuriano23 opened this issue Nov 9, 2022 · 0 comments
Labels
3.11 3.12 expert-asyncio type-bug An unexpected behavior, bug, or error

Comments

@csuriano23
Copy link
Contributor

csuriano23 commented Nov 9, 2022 •
edited by bedevere-bot

Bug report

In python 3.11 asyncio module, a new version of set_write_buffer_limits and get_write_buffer_limits has been introduced for SSL (sslproto.py), that doesn't delegate to the transport layer. However the old version of get_write_buffer_limits is still inplace, overwriting the new version

Your environment

CPython versions tested on:

  • 3.10.x (no bug)
  • 3.11.0

Operating system and architecture:

  • Darwin, MacOS ARM M1
@csuriano23 csuriano23 added the type-bug An unexpected behavior, bug, or error label Nov 9, 2022
This was referenced Nov 9, 2022
Merged
Merged
gvanrossum pushed a commit that referenced this issue Nov 10, 2022
@csuriano23 @kumaraditya303
gh-99277: remove older version of get_write_buffer_limits (#99280)
f1680c3 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 10, 2022
@csuriano23 @kumaraditya303 @miss-islington
pythongh-99277: remove older version of get_write_buffer_limits (py…
52bace9 
…thonGH-99280)

(cherry picked from commit f1680c3)

Co-authored-by: Carlo <34414634+csuriano23@users.noreply.github.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
Merged
gvanrossum pushed a commit that referenced this issue Nov 10, 2022
@miss-islington @csuriano23 @kumaraditya303
[3.11] gh-99277: remove older version of get_write_buffer_limits (G…
0dfbb76 
…H-99280) (#99338)

(cherry picked from commit f1680c3)

Co-authored-by: Carlo <34414634+csuriano23@users.noreply.github.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Nov 10, 2022
@csuriano23 @kumaraditya303 @gvanrossum
pythongh-99277: remove older version of get_write_buffer_limits (py…
882fdec 
…thon#99280)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
ethanfurman pushed a commit to ethanfurman/cpython that referenced this issue Nov 12, 2022
@csuriano23 @kumaraditya303 @ethanfurman
pythongh-99277: remove older version of get_write_buffer_limits (py…
2f88446 
…thon#99280)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 3.12 expert-asyncio type-bug An unexpected behavior, bug, or error
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvanrossum @csuriano23 @kumaraditya303