Skip to content

CI: compile-queries: use cache when running on main, and support more base-branches#11180

Merged
erik-krogh merged 10 commits intogithub:mainfrom
erik-krogh:yetMoreCi
Nov 9, 2022
Merged

CI: compile-queries: use cache when running on main, and support more base-branches#11180
erik-krogh merged 10 commits intogithub:mainfrom
erik-krogh:yetMoreCi

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Nov 9, 2022

Followup to #11162

@erik-krogh erik-krogh marked this pull request as ready for review November 9, 2022 11:40
@erik-krogh erik-krogh requested a review from a team as a code owner November 9, 2022 11:40
@erik-krogh erik-krogh requested a review from aibaars November 9, 2022 11:40
@erik-krogh
Copy link
Contributor Author

The use base_ref to calculate the cache-keys when running in a PR. commit was a little late.
I had forgotten to save the file, so my commit didn't include those changes.

@erik-krogh erik-krogh requested a review from aibaars November 9, 2022 11:58
@erik-krogh erik-krogh force-pushed the yetMoreCi branch 2 times, most recently from 5c4cb21 to d1c17a6 Compare November 9, 2022 13:36
codeql-compile-main-${{ env.merge-base }}
codeql-compile-main-
codeql-compile-refs/heads/${{ github.base_ref }}-${{ env.merge-base }}
codeql-compile-refs/heads/${{ github.base_ref }}-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps fall back to main too, just in case. It won't matter much in practice as most PR will target main anyway.

Suggested change
codeql-compile-refs/heads/${{ github.base_ref }}-
codeql-compile-refs/heads/${{ github.base_ref }}-
codeql-compile-refs/heads/main-

Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@erik-krogh erik-krogh merged commit d35e5ac into github:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants