C++: Clearer messages for the format args queries #11149
Merged
+58
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
approved these changes
Nov 7, 2022
|
Agree on both points. I'll update the internal test... |
|
I've created an internal PR to update the internal test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Makes the messages from the
cpp/too-many-format-argumentsandcpp/wrong-number-format-argumentsqueries a bit clearer in cases where macros are hiding the formatting function call in question. Motivated by a real case that took a bit of investigation before anyone realized it was a TP.No change note required because results should be the same apart from clarification in the messages.