Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] gh-97514: Don't use Linux abstract sockets for multiprocessing (GH-98501) #98503

Merged
merged 1 commit into from Oct 20, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 20, 2022

Linux abstract sockets are insecure as they lack any form of filesystem
permissions so their use allows anyone on the system to inject code into
the process.

This removes the default preference for abstract sockets in
multiprocessing introduced in Python 3.9+ via
#18866 while fixing
#84031.

Explicit use of an abstract socket by a user now generates a
RuntimeWarning. If we choose to keep this warning, it should be
backported to the 3.7 and 3.8 branches.
(cherry picked from commit 49f6106)

Co-authored-by: Gregory P. Smith greg@krypto.org

Automerge-Triggered-By: GH:gpshead

…ythonGH-98501)

Linux abstract sockets are insecure as they lack any form of filesystem
permissions so their use allows anyone on the system to inject code into
the process.

This removes the default preference for abstract sockets in
multiprocessing introduced in Python 3.9+ via
python#18866 while fixing
python#84031.

Explicit use of an abstract socket by a user now generates a
RuntimeWarning.  If we choose to keep this warning, it should be
backported to the 3.7 and 3.8 branches.
(cherry picked from commit 49f6106)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-security A security issue awaiting review labels Oct 20, 2022
@gpshead gpshead requested a review from pablogsal Oct 20, 2022
@gpshead gpshead added release-blocker 🤖 automerge PR will be merged once it's been approved and all CI passed labels Oct 20, 2022
@miss-islington miss-islington merged commit eae692e into python:3.10 Oct 20, 2022
14 checks passed
@miss-islington miss-islington deleted the backport-49f6106-3.10 branch Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker 🤖 automerge PR will be merged once it's been approved and all CI passed type-bug An unexpected behavior, bug, or error type-security A security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants