Hi there 👋
@jonrohan
Pinned
3,398 contributions in the last year
Less
More
Activity overview
Contributed to
primer/view_components,
primer/css,
primer/stylelint-config
and 22 other
repositories
Contribution activity
October 2022
Created 60 commits in 2 repositories
Created a pull request in primer/primitives that received 6 comments
Opened 40 other pull requests in 1 repository
primer/view_components
32
merged
4
open
4
closed
- Changing actions workflows to use ruby/setup-ruby
- Write test to make sure asset naming matches component
- Bug Fix: Fixing bad CSS in action-list.css and writing test to check for error
- Export component CSS selectors as json file for testing
- Stack layout component
- Adding testing around writing previews
- Updates to dependabot config to upgrade production packages (actions, npm, gems)
- Combine labeler and check for change into triage
- Combine docs and demo deploy workflows
- Adding view components version to lookbook title
- Upgrade simplecov to latest version, and adjust testing of coverage in actions
-
Consolidate tests for linting rules in the
test/lib/folder and getting Component test coverage to 100% - Fix missing components.json
- Using Lookbook's new dynamic display variables to toggle themes
- Building PostCSS components separately
- Adding docs hero banner to PVC site
- Deploy production docs and lookbook app only when a release is created
- Consolidate docs folders into docs/
- Adding a pull request template
- Upgrades to our PostCSS build toolkit
- Removing view_component/engine
- Removing deprecated Primer::HeadingComponent
- Removing deprecated Primer::CloseButton
- Removing Primer::DetailsComponent
- Removing deprecated HiddenTextExpander
- Some pull requests not shown.
Reviewed 42 pull requests in 6 repositories
primer/view_components
25 pull requests
- Export component CSS selectors as json file for testing
- Release Tracking
- Banner component
- Disable cops for erblint only
- migrate Primer::LinkComponent to Primer::Beta::LinkComponent
- migrating Primer::LabelComponent to Primer::Beta::Label
-
rubocop/config/default: Unset
DisabledByDefault - Updates to the flash component to use new banner styles
- migrating Primer::ImageCrop to Primer::Alpha::ImageCrop
- Migrate Primer::Image to Primer::Alpha::Image
-
Consolidate tests for linting rules in the
test/lib/folder and getting Component test coverage to 100% - Release Tracking
- Pass select list options to Rails form builder
- Upgrade simplecov to latest version, and adjust testing of coverage in actions
- Roll back Doctocat upgrade
- Icon button hide tooltip
- Fix our custom Octicon input type in Lookbook
- Remove dead SCSS code from ActionList
- Release Tracking
- Move sample forms out of test folder
- move tooltip to be adjacent to button
- Only register click handler once
- Bump view_component to 2.74.1 to fix deadlock issues in Lookbook
- Nested dialogs
- Run script with bash
- Some pull request reviews not shown.
primer/css
4 pull requests
github/details-menu-element
1 pull request
primer/contribute
1 pull request
ViewComponent/lookbook
1 pull request
primer/octicons
1 pull request
Opened 2 issues in 2 repositories
primer/doctocat
1
open
primer/view_components
1
closed
Started 1 discussion in 1 repository
primer/view_components
primer/view_components
-
How do we run scripts in the project?
This contribution was made on Oct 10
Joined the ViewComponent organization
ViewComponent
A framework for creating reusable, testable & encapsulated view components, built to integrate seamlessly with Ruby on Rails.
82
contributions
in private repositories
Oct 5 – Oct 26