Skip to content

qlpacks: libraryPathDependencies -> dependencies#10964

Merged
dbartol merged 3 commits intogithub:mainfrom
smowton:smowton/admin/modernise-qlpacks
Oct 28, 2022
Merged

qlpacks: libraryPathDependencies -> dependencies#10964
dbartol merged 3 commits intogithub:mainfrom
smowton:smowton/admin/modernise-qlpacks

Conversation

@smowton
Copy link
Copy Markdown
Contributor

@smowton smowton commented Oct 25, 2022

This is an initial stab at just removing all references to the deprecated key. I note though that a bunch of these files are named legacy-xyz -- I don't know what these are doing or if they have a reason to use the deprecated key (compatibility with an old codeql?)

@smowton smowton requested review from a team as code owners October 25, 2022 09:33
RasmusWL
RasmusWL previously approved these changes Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@RasmusWL RasmusWL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks 💪 (related PR: #7842)

@erik-krogh
Copy link
Copy Markdown
Contributor

erik-krogh commented Oct 25, 2022

QL-for-QL fails to build because the version of the shared typos pack was bumped, but the version specified in ql/ql/src/qlpack.yml wasn't bumped.
We should somehow ensure that those are kept in sync, but for now you can manually bump the version.

@smowton smowton force-pushed the smowton/admin/modernise-qlpacks branch from 141bbbc to 5ad5cdc Compare October 28, 2022 15:08
aeisenberg
aeisenberg reviewed Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly all new packs and tests should be using the new syntax.

I'm hesitant to change any of the legacy-support packs (until I learn more about what they are). I would also like to retain at least one test for legacy syntax.

dbartol
dbartol suggested changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all of the changes to the legacy-support packs as discussed in Slack.

Also, I'm assuming that the rest of these dependencies are all to packs in the same repo? If so, then all of the '*' version ranges should be replaced with ${workspace}, which means "whatever version is currently in the same repo". It's not particularly important for query packs, but for library packs that we might eventually publish, it ensures that other consumers of that library pack actually get a compatible version of that dependency.

@smowton
Copy link
Copy Markdown
Contributor Author

smowton commented Oct 28, 2022

Legacy packs reverted; left * alone for now since this is also in use all over the repo, so I'd suggest following up with a different PR rather than broaden this one's scope

dbartol
dbartol approved these changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aeisenberg
aeisenberg approved these changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@dbartol dbartol merged commit 85790fc into github:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

@RasmusWL RasmusWL RasmusWL left review comments

+1 more reviewer

@dbartol dbartol dbartol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C# Go Java Python QL-for-QL Swift

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smowton @erik-krogh @aeisenberg @RasmusWL @dbartol