Ruby: Model some ActiveSupport methods #10700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadee98 to
62cb31a
Compare
nickrolfe
reviewed
Oct 19, 2022
| } | ||
|
|
||
| /** | ||
| * Extensions to the `Hash` class. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Extensions to the `Hash` class. | |
| * Extensions to the `Hash` class. |
| result = DataFlow::Content::getKnownElementIndex(mc.getArgument(i)).serialize() | ||
| } | ||
|
|
||
| private class ExtractSummary extends SummarizedCallable { |
Contributor
There was a problem hiding this comment.
This summary is sufficiently complicated that I can't quite follow what it's doing. Could you add a comment, perhaps with an example call to extract! and then an explanation of the flow step we're adding?
Contributor
Author
|
CI seems to have got stuck for some reason. I'll rebase this PR in the hope that unsticks it. |
The type-tracking flow tests document the difference in sensitivity between type-tracking and dataflow, so failures in that test are expected.
This is already tested in hash-flow.
Contributor
Author
|
@alexrford could a get a 👍 on this again when you have a chance? CI has fixed itself now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model many ActiveSupport extensions to
String,HashandObject.