Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: NO_COLOR setting not respected in gh upgrade notice #6510

Merged
merged 1 commit into from Oct 26, 2022
Merged

Fix: NO_COLOR setting not respected in gh upgrade notice #6510

merged 1 commit into from Oct 26, 2022
+1 −0

Conversation

dojutsu-user
Copy link
Contributor

@dojutsu-user dojutsu-user commented Oct 25, 2022

Fixes: #6495

Disabling colors in ansi is sufficient to fix the error.

@dojutsu-user dojutsu-user marked this pull request as ready for review Oct 25, 2022
@dojutsu-user dojutsu-user requested a review from a team as a code owner Oct 25, 2022
@dojutsu-user dojutsu-user requested review from samcoe (assigned from cli/code-reviewers) and removed request for a team Oct 25, 2022
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Oct 25, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Oct 25, 2022
mislav
mislav approved these changes Oct 26, 2022
View changes
Copy link
Member

@mislav mislav left a comment

Thank you!

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Oct 26, 2022
@mislav mislav enabled auto-merge Oct 26, 2022
@mislav mislav merged commit 9ea7623 into cli:trunk Oct 26, 2022
8 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Oct 26, 2022
@dojutsu-user dojutsu-user deleted the no_color_6495 branch Oct 26, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Nov 3, 2022
@LangLangBart LangLangBart mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav

@samcoe samcoe

Assignees
No one assigned
Labels
external pull request originating outside of the CLI core team
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NO_COLOR setting not respected in gh upgrade notice
3 participants
@dojutsu-user @mislav @cliAutomation