JS: fix some more style-guide violations in the alert-messages#10727
Merged
erik-krogh merged 2 commits intogithub:mainfrom Oct 27, 2022
Merged
JS: fix some more style-guide violations in the alert-messages#10727erik-krogh merged 2 commits intogithub:mainfrom
erik-krogh merged 2 commits intogithub:mainfrom
Conversation
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
kaeluka
approved these changes
Oct 27, 2022
kaeluka
left a comment
There was a problem hiding this comment.
I only gave this a spot check, as it's quite large. But it LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One last PR, where I went through the alerts produced by QL-for-QL.
Ignore the QL-for-QL alerts, I'm also changing the alert-messages in those other languages.