Migrate to tableprinter from go-gh #6346
Merged
+115
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new
The utils tableprinter is now deprecated. |
josebalius
reviewed
Oct 10, 2022
| @@ -86,6 +86,7 @@ func (a *App) List(ctx context.Context, opts *listOptions, exporter cmdutil.Expo | |||
| return cmdutil.NewNoResultsError("no codespaces found") | |||
| } | |||
|
|
|||
| //nolint:staticcheck // SA1019: utils.NewTablePrinter is deprecated: use internal/tableprinter | |||
There was a problem hiding this comment.
Should the team create an issue to migrate these, or are you planning to tackle this as part of some other work?
cc @cmbrose (not sure who's "owning" cs CLI these days)
There was a problem hiding this comment.
Good question. Codespace team: feel free to ignore this. It's a codebase-wide deprecation and doesn't need to be immediately addressed specifically for codespaces. The deprecation is mostly to avoid new code importing the legacy utils package.
samcoe
reviewed
Oct 12, 2022
samcoe
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Tableprinter now lives as a go-gh package with a nicer API. This migrates to using it behind the original, legacy API.
TODO