Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all .txt PEP files to .rst #462

Merged
merged 1 commit into from Nov 11, 2017
Merged

Rename all .txt PEP files to .rst #462

merged 1 commit into from Nov 11, 2017

Conversation

@mozillazg
Copy link
Contributor

@mozillazg mozillazg commented Nov 11, 2017

Only rename files, others PR will update pep2html.py and pep0.
@Mariatta Mariatta merged commit bb0e518 into python:master Nov 11, 2017
1 check passed
@Mariatta
Copy link
Sponsor Member

@Mariatta Mariatta commented Nov 11, 2017

Thanks @mozillazg!

Mariatta added a commit to Mariatta/peps that referenced this issue Nov 11, 2017
@Mariatta
Revert "Rename all .txt PEP files to .rst (pythonGH-462)"
df2866e 
This reverts commit bb0e518.
Mariatta pushed a commit that referenced this issue Nov 11, 2017
Revert "Rename all .txt PEP files to .rst (GH-462)" (GH-464)
cf3bad5 
This reverts commit bb0e518.
@Mariatta
Copy link
Sponsor Member

@Mariatta Mariatta commented Nov 11, 2017

Sorry @mozillazg. After I merged your PR, it erased the history of the PEPs; each pep-*.rst was treated as a brand new file. So I had to revert your changes to retain the history.

@methane
Copy link
Member

@methane methane commented Nov 11, 2017

@Mariatta
Copy link
Sponsor Member

@Mariatta Mariatta commented Nov 12, 2017

@methane, sorry, 'erased' was the wrong word I shouldn't have used it. What happened was that when a file was renamed, GitHub is only showing the new file history since the rename. So after pep-0008.txt was renamed to pep-0008.rst, on GitHub I could no longer see all the revision ever made to PEP 8.
On the command line, git log pep-0008.rst also does not show the complete revision history. Only that it was renamed. We have to do git log --follow pep-0008.rst to get the complete history.
I think not being able to easily see the history in GitHub is inconvenient and I'm not comfortable with it.
So I reverted the commit for now. (everything is in . txt again).

@Mariatta Mariatta mentioned this pull request Nov 12, 2017
Closed
@kosayoda kosayoda mentioned this pull request May 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@mozillazg @Mariatta @methane @the-knights-who-say-ni