Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Typing Topic #2670

Merged
merged 7 commits into from Oct 7, 2022
Merged

Add Typing Topic #2670

merged 7 commits into from Oct 7, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Jun 25, 2022

No description provided.

@JelleZijlstra @CAM-Gerlach
Update pep_sphinx_extensions/pep_zero_generator/constants.py
613c27c 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@JelleZijlstra JelleZijlstra marked this pull request as ready for review Jul 1, 2022
CAM-Gerlach
CAM-Gerlach reviewed Jul 2, 2022
View changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

At least in the packaging PEPs, we put the Topic below the Type, which seems to make sense, so probably worth being consistent here like the other headers are.

Also, one wording suggestion.

pep-0482.txt Outdated Show resolved Hide resolved
pep_sphinx_extensions/pep_zero_generator/constants.py Show resolved Hide resolved
@CAM-Gerlach CAM-Gerlach added enhancement meta Related to the repo itself and its processes labels Jul 2, 2022
@JelleZijlstra JelleZijlstra requested a review from CAM-Gerlach Oct 4, 2022
@CAM-Gerlach CAM-Gerlach changed the title Add typing Topic Add Typing Topic Oct 7, 2022
CAM-Gerlach
CAM-Gerlach approved these changes Oct 7, 2022
View changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

LGTM now; thanks @JelleZijlstra

@JelleZijlstra JelleZijlstra merged commit 83b976d into python:main Oct 7, 2022
15 checks passed
@JelleZijlstra JelleZijlstra deleted the topictyping branch Oct 7, 2022
@hugovk
Copy link
Member

hugovk commented Oct 7, 2022

And it's live!

https://peps.python.org/topic/typing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach

@gvanrossum gvanrossum

@larryhastings larryhastings

@ilevkivskyi ilevkivskyi

@ambv ambv

@lisroach lisroach

@AA-Turner AA-Turner

Assignees
No one assigned
Labels
enhancement meta Related to the repo itself and its processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JelleZijlstra @hugovk @CAM-Gerlach