Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the 'Created' field #1805

Merged
merged 1 commit into from Feb 9, 2021

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Feb 7, 2021

All PEPs now follow the format specified in PEP 1: dd-mmm-yyyy which corresponds to %d-%b-%Y.

Copy link
Member

@gvanrossum gvanrossum left a comment

Note that there was a typo in your description (yyy -> yyyy).

Are you going to do the other date fields too?

@encukou
Copy link
Member

encukou commented Feb 8, 2021

dd-mmm-yyyy which corresponds to %d-%b-%Y.

Only with some locales. Sometimes, %d-%b-%Y gives me 08-úno-2021.

Would it be reasonable to change PEP 1 to a format that's independent of locale, like %Y-%m-%d (2021-02-08)?

@gvanrossum
Copy link
Member

gvanrossum commented Feb 9, 2021

Can we first land this? There are too many pending PRs relating to this minor issue.

Re: the idea of using a different format needs much more consideration before it can be made to work -- personally I'd prefer to keep the current format and just state it has to be the English locale (like the rest of the text has to be in English).

@encukou
Copy link
Member

encukou commented Feb 9, 2021

Sure – if you've considered the locale issue, go ahead!

(I'm just raising the point because, IMO, this is the time it should be considered. The more automation is built around it, the harder it'll be to change.)

@gvanrossum gvanrossum merged commit bb47513 into python:master Feb 9, 2021
1 check passed
@brettcannon
Copy link
Member Author

brettcannon commented Feb 9, 2021

@gvanrossum I only did this to mine the PEPs for creation date details, so my itch is scratched at this point. 😉

@brettcannon brettcannon deleted the normalize-creation-date branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants