New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] gh-68966: Make mailcap refuse to match unsafe filenames/types/params (GH-91993) #93543
base: 3.10
Are you sure you want to change the base?
Conversation
…arams (pythonGH-91993) (cherry picked from commit b9509ba) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
@pablogsal, do you agree? |
I agree, but I am still not confident on backporting it, so unless there is some clear consensus from everyone I would recommend to be cautious here. |
|
Status check is done, and it's a success |
|
Who's "everyone"? |
|
Everyone is any core Dev interested on mailcap that want to voice their opinion. If nobody objects or everyone is just you and @gpshead then go ahead and merge it :) |
|
So let's ping core devs from the original issue – but I doubt even they are particularly interested in mailcap. @zooba @brettcannon @vstinner, do you agree with Greg?
|
| @@ -60,6 +60,18 @@ standard. However, mailcap files are supported on most Unix systems. | |||
| use) to determine whether or not the mailcap line applies. :func:`findmatch` | |||
| will automatically check such conditions and skip the entry if the check fails. | |||
|
|
|||
| .. versionchanged:: 3.11 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update with the 3.10.x version number for this branch.
Correct, I am not interested and thus have no opinion. |
|
My only strong preference is that there should be a clear what's new entry that specifies at least the name of the warning, to give users encountering this the best possible chance to figure out what has changed (and that it was us, and not something that they did). |
(cherry picked from commit b9509ba)
Co-authored-by: Petr Viktorin encukou@gmail.com