Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ccache-action to one using Node 16 #98166

Merged
merged 1 commit into from Oct 11, 2022

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Oct 10, 2022

Github Actions has deprecated the use of Node 12, and will be turning it off by summer 2023.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

I found this because I have been experimenting with various Github Action things in my own fork and was getting this warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: hendrikmuhs/ccache-action, hendrikmuhs/ccache-action

Unfortunately, we aren't getting this warning on the main CPython fork because there is a bug displaying these warnings in composite actions: actions/runner#1742

Nonetheless, probably worth upgrading this.

@AA-Turner
Copy link
Member

AA-Turner commented Oct 11, 2022

The backport to 3.10 won't be clean, but it should probably be updated too.

@ambv Should this also be backported to 3.8/3.9? Both use ccache-action, and both have end-of-life dates post Summer 2023 so may run in to this.

A

@ambv
Copy link
Contributor

ambv commented Oct 11, 2022

Yes, let's backport 3.8 and 3.9 as well.

@ambv ambv merged commit ad8e297 into python:main Oct 11, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2022

Thanks @mdboom for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2022

Sorry, @mdboom and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ad8e297b7297dfdc34fad53b589b31d0920150ab 3.10

@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2022

GH-98182 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2022

Sorry @mdboom and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ad8e297b7297dfdc34fad53b589b31d0920150ab 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2022

Sorry, @mdboom and @ambv, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ad8e297b7297dfdc34fad53b589b31d0920150ab 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2022
Github Actions has deprecated the use of Node 12, and will be turning it off by
summer 2023.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
(cherry picked from commit ad8e297)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@ambv
Copy link
Contributor

ambv commented Oct 11, 2022

I'll make the backports.

miss-islington added a commit that referenced this pull request Oct 15, 2022
Github Actions has deprecated the use of Node 12, and will be turning it off by
summer 2023.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
(cherry picked from commit ad8e297)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants