fs: add validateBuffer to improve error
#44769
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Sep 24, 2022
test/parallel/test-fs-read.js
Outdated
| { | ||
| name: 'TypeError', | ||
| message: 'The "buffer" argument must be an instance of Buffer, ' + | ||
| 'TypedArray, or DataView. Received null', | ||
| }, |
There was a problem hiding this comment.
Let's not validate the message, but rather the error code.
Suggested change
| { | |
| name: 'TypeError', | |
| message: 'The "buffer" argument must be an instance of Buffer, ' + | |
| 'TypedArray, or DataView. Received null', | |
| }, | |
| { code: 'ERR_INVALID_ARG_TYPE' }, |
|
/cc @nodejs/fs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
when
paramsis{ buffer: null },bufferis not initialized withBuffer.alloc(16384). so error message became not user-friendly as seen in test case.node/lib/fs.js
Line 621 in abfeed8