Skip to content

Upgrade devcontainer config#6405

Merged
mislav merged 5 commits intocli:trunkfrom
jungaretti:jungaretti/new-devcontainer
Oct 11, 2022
Merged

Upgrade devcontainer config#6405
mislav merged 5 commits intocli:trunkfrom
jungaretti:jungaretti/new-devcontainer

Conversation

@jungaretti
Copy link
Copy Markdown
Contributor

@jungaretti jungaretti commented Oct 8, 2022

Upgrades this repo's devcontainer to adopt the latest and greatest devcontainer features:

  • Uses an image from the new devcontainers/images repo
  • Adds the GitHub CLI feature
  • Adds SSH feature

Create a new codespace using this devcontainer: https://github.com/codespaces/new/?repo=543812098&ref=jungaretti%2Fnew-devcontainer

@jungaretti jungaretti requested a review from a team as a code owner October 8, 2022 07:51
@jungaretti jungaretti requested review from mislav and removed request for a team October 8, 2022 07:51
@cliAutomation
Copy link
Copy Markdown
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Oct 8, 2022
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread .devcontainer/devcontainer.json Outdated
Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Thank you for helping make the devcontainer better

Comment thread .devcontainer/devcontainer.json Outdated
Comment thread .devcontainer/devcontainer.json Outdated
@jungaretti jungaretti requested a review from mislav October 10, 2022 20:43
Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! <3

@mislav mislav merged commit 88775a2 into cli:trunk Oct 11, 2022
@Truonghau83 Truonghau83 mentioned this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants