Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mntly/extension not found #6425

Merged
merged 6 commits into from Oct 14, 2022
Merged

mntly/extension not found #6425

merged 6 commits into from Oct 14, 2022
+92 −15

Conversation

mntlty
Copy link
Contributor

@mntlty mntlty commented Oct 12, 2022

fixes #6397

Changed the naked returns in hasScript to be explicit for readability.

@mntlty mntlty marked this pull request as ready for review Oct 12, 2022
@mntlty mntlty requested a review from a team as a code owner Oct 12, 2022
@mntlty mntlty requested review from vilmibm (assigned from cli/code-reviewers) and removed request for a team Oct 12, 2022
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Oct 12, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Oct 12, 2022
samcoe
samcoe reviewed Oct 12, 2022
View changes
Copy link
Member

@samcoe samcoe left a comment

@mntlty Thanks for hopping on this issue. Left a couple comments/questions for you.

pkg/cmd/extension/http.go Show resolved Hide resolved
pkg/cmd/extension/http.go Outdated Show resolved Hide resolved
@mislav
Copy link
Member

mislav commented Oct 12, 2022

Thanks for working on this @mntlty! 🎉

mntlty
mntlty commented Oct 13, 2022
View changes
pkg/cmd/extension/http.go Outdated Show resolved Hide resolved
mislav
mislav approved these changes Oct 13, 2022
View changes
pkg/cmd/extension/manager_test.go Outdated Show resolved Hide resolved
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Oct 13, 2022
mislav
mislav approved these changes Oct 14, 2022
View changes
Copy link
Member

@mislav mislav left a comment

Thank you! I've pushed some fixes and simplifications.

@mntlty
Copy link
Contributor Author

mntlty commented Oct 14, 2022

Thank you! I've pushed some fixes and simplifications.

Thank you!

@mislav mislav merged commit abb8c86 into trunk Oct 14, 2022
10 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Oct 14, 2022
@mislav mislav deleted the mntly/extension_not_found branch Oct 14, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe

@mislav mislav

@vilmibm vilmibm

Assignees
No one assigned
Labels
external pull request originating outside of the CLI core team
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearer error message for unfound extensions
4 participants
@mntlty @mislav @samcoe @cliAutomation