Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust c-api reference counting docs to reference Py_REFCNT, Py_SET_REFCNT #96258

Closed
QuakeIV opened this issue Aug 25, 2022 · 2 comments
Closed

adjust c-api reference counting docs to reference Py_REFCNT, Py_SET_REFCNT #96258

QuakeIV opened this issue Aug 25, 2022 · 2 comments
Labels
docs Documentation in the Doc dir

Comments

@QuakeIV
Copy link
Contributor

QuakeIV commented Aug 25, 2022 •
edited

Currently when you go to the reference counting page (https://docs.python.org/3/c-api/refcounting.html) it does not make any mention of the existence of Py_REFCNT or Py_SET_REFCNT, it would be nice if it did so. I had briefly thought there was no macro to check the reference count. After realizing there in fact was, it occurred to me I could probably make a change request.

Made an associated pull request proposing a specific change here: #96259
@QuakeIV QuakeIV added the docs Documentation in the Doc dir label Aug 25, 2022
@bedevere-bot bedevere-bot mentioned this issue Aug 25, 2022
Merged
@QuakeIV
Copy link
Contributor Author

QuakeIV commented Aug 26, 2022

as suggested by mdboom in the PR, just moving them to refcounting instead

JelleZijlstra pushed a commit that referenced this issue Oct 15, 2022
@QuakeIV
gh-96258: move Py_REFCNT and Py_SET_REFCNT to reference counting page (…
4e2bd58 
…#96259)
@QuakeIV
Copy link
Contributor Author

QuakeIV commented Oct 20, 2022

merged

@QuakeIV QuakeIV closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuakeIV