Python: DB Modeling: Add pymssql and executemany in general#10752
Merged
RasmusWL merged 6 commits intogithub:mainfrom Oct 11, 2022
Merged
Python: DB Modeling: Add pymssql and executemany in general#10752RasmusWL merged 6 commits intogithub:mainfrom
pymssql and executemany in general#10752RasmusWL merged 6 commits intogithub:mainfrom
Conversation
I also forgot to mention `PyMySQL` in frameworks.rst
Note: I kept the modeling using the old approach with type-trackers instead of `DataFlow::MethodCallNode`. I would like a meta query for DCA to show sinks before doing this, so I can be absolutely sure we don't loose out on any important sinks on this... so will postpone this work to a small one-off task (added to my todo list).
tausbn
previously approved these changes
Oct 10, 2022
Contributor
tausbn
left a comment
There was a problem hiding this comment.
One minor comment, otherwise this looks good to me. 👍
python/ql/src/change-notes/2022-10-10-pep249-executemany-modeling.md
Outdated
Show resolved
Hide resolved
tausbn
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is actually 2 major features:
pymssqlpackageexecutemanyon PEP-249 DB APIsI just stuck them together, since it was only the modeling of
pymssqlthat made me realize we were missing theexecutemanycalls 😳