Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96143: subprocess API %s/universal_newlines=/text=/g. #96468

Merged
merged 1 commit into from Sep 1, 2022
Merged

gh-96143: subprocess API %s/universal_newlines=/text=/g. #96468

merged 1 commit into from Sep 1, 2022

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Sep 1, 2022 •
edited by miss-islington

minor missed test cleanup to use the modern API from the big review.

Automerge-Triggered-By: GH:gpshead

@gpshead gpshead added tests Tests in the Lib/test dir skip news labels Sep 1, 2022
@gpshead gpshead added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Sep 1, 2022
@gpshead gpshead requested a review from pablogsal Sep 1, 2022
@miss-islington miss-islington merged commit e93d1bd into python:main Sep 1, 2022
12 checks passed
@pablogsal
Copy link
Member

pablogsal commented Sep 1, 2022

Thanks @gpshead and apologies for missing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gpshead @pablogsal @bedevere-bot @miss-islington