test: remove test-gc-http-client-timeout from flaky list #43971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Jul 24, 2022
legendecas
approved these changes
Jul 24, 2022
|
Fast-track has been requested by @F3n67u. Please |
RaisinTen
approved these changes
Jul 25, 2022
@RaisinTen I will close #43638 manually.
See #43638 (comment) for more info. |
Commit Queue failed- Loading data for nodejs/node/pull/43971 ✔ Done loading data for nodejs/node/pull/43971 ----------------------------------- PR info ------------------------------------ Title test: remove test-gc-http-client-timeout from flaky list (#43971) Author Feng Yu (@F3n67u) Branch F3n67u:remove-flaky -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: remove test-gc-http-client-timeout from flaky list Committers 1 - Feng Yu PR-URL: https://github.com/nodejs/node/pull/43971 Refs: https://github.com/nodejs/node/pull/43949 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Chengzhong Wu Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43971 Refs: https://github.com/nodejs/node/pull/43949 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Chengzhong Wu Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 24 Jul 2022 14:33:41 GMT ✔ Approvals: 4 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048652141 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048654802 ✔ - Chengzhong Wu (@legendecas): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048659219 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048859564 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-24T14:46:37Z: https://ci.nodejs.org/job/node-test-pull-request/45652/ - Querying data for job/node-test-pull-request/45652/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2737039353 |
|
Landed in fbcac58 |
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
PR-URL: nodejs#43971 Refs: nodejs#43949 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
test-gc-http-client-timeouthas been fixed by #43949, let us remove it from flaky list.Refs:
#43949
#43754