crypto: make authTagLength optional for CC20P1305 #42427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
32 tasks
28 tasks
29 tasks
27 tasks
jasnell
approved these changes
Mar 25, 2022
26 tasks
panva
approved these changes
Mar 26, 2022
26 tasks
|
Landed in 934a3aa |
24 tasks
juanarbol
pushed a commit
that referenced
this issue
Apr 4, 2022
PR-URL: #42427 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this issue
Apr 5, 2022
PR-URL: nodejs#42427 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Closed
Merged
juanarbol
added a commit
that referenced
this issue
Apr 6, 2022
juanarbol
added a commit
that referenced
this issue
Apr 6, 2022
juanarbol
pushed a commit
that referenced
this issue
Apr 6, 2022
PR-URL: #42427 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
juanarbol
added a commit
that referenced
this issue
Apr 7, 2022
juanarbol
added a commit
that referenced
this issue
Apr 7, 2022
juanarbol
added a commit
that referenced
this issue
Apr 7, 2022
juanarbol
added a commit
that referenced
this issue
Apr 7, 2022
xtx1130
pushed a commit
to xtx1130/node
that referenced
this issue
Apr 25, 2022
PR-URL: nodejs#42427 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this issue
Apr 25, 2022
Notable Changes: * (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) nodejs#42427 * deps: update undici to 4.16.0 (Node.js GitHub Bot) nodejs#42414 * doc: add @meixg to collaborators (Xuguang Mei) nodejs#42576 PR-URL: nodejs#42613
juanarbol
pushed a commit
that referenced
this issue
May 31, 2022
PR-URL: #42427 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
16 bytes are the standard authentication tag length for ChaCha20-Poly1305 because Poly1305 produces exactly 16 bytes. Almost all use cases for ChaCha20-Poly1305 will want to use an authentication tag length of 16 bytes.
This is similar to GCM, for which Node.js already defaults to 16 bytes, except that there are approved shorter authentication tag lengths for GCM. For Poly1305, there are none, so when decrypting, GCM will silently accept shorter tags as long as their length is valid, whereas, with this change, ChaCha20-Poly1305 will still require 16 byte tags unless a different
authTagLengthhas been specified.