Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add shared files in experimental to identical-files.json. #10487

Merged
merged 4 commits into from Sep 20, 2022

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Sep 20, 2022

When we retargeted #10366 to experimental we added a couple of copies of the shared dataflow library. However, I forgot to add those to identical-files.json. This PR fixes that.

@MathiasVP MathiasVP added the C++ label Sep 20, 2022
@github-actions github-actions bot removed the C++ label Sep 20, 2022
@MathiasVP MathiasVP requested a review from a team as a code owner Sep 20, 2022
@github-actions github-actions bot added the C++ label Sep 20, 2022
redsun82
redsun82 previously approved these changes Sep 20, 2022
Copy link
Contributor

@redsun82 redsun82 left a comment

:shipit:

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Otherwise LGTM.

config/identical-files.json Outdated Show resolved Hide resolved
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
@MathiasVP MathiasVP merged commit 9d50fc6 into github:main Sep 20, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants