Skip to content

Make a few minor contributions#20738

Merged
jhosman merged 5 commits intogithub:mainfrom
applecuckoo:main
Sep 22, 2022
Merged

Make a few minor contributions#20738
jhosman merged 5 commits intogithub:mainfrom
applecuckoo:main

Conversation

@applecuckoo
Copy link
Contributor

@applecuckoo applecuckoo commented Sep 21, 2022

Just correcting a small typo and changing key. Fixes #20508

Why:

Fixing a small typo in the docs and changing subkey in paste-gpg-key-id.md to match copy-gpg-key-id.md 📝

What's being changed (if available, include any code snippets, screenshots, or gifs):

- Once your PR is merged, your contributions will be publicly visible on the [GitHubs docs](https://docs.github.com/en). 
+ Once your PR is merged, your contributions will be publicly visible on the [GitHub docs](https://docs.github.com/en). 
- Alternatively, when setting a subkey include the `!` suffix. In this example, the GPG subkey ID is `4BB6D45482678BE3`:
+ Alternatively, when setting a subkey include the `!` suffix. In this example, the GPG subkey ID is `42B317FD4BA89E7A`:
```shell
- $ git config --global user.signingkey <em>4BB6D45482678BE3</em>!
+ $ git config --global user.signingkey <em>42B317FD4BA89E7A</em>!

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Just correcting a small typo
@welcome
Copy link

welcome bot commented Sep 21, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 21, 2022
@applecuckoo
Copy link
Contributor Author

Hey there folks, not too sure what the 'changes in staging' checkbox means so I've leaved that unticked.

@cmwilson21
Copy link
Contributor

@applecuckoo Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Sep 21, 2022
@applecuckoo applecuckoo changed the title Remove extra 's' from GitHub in CONTRIBUTING Make a few minor contributions Sep 21, 2022
Copy link
Contributor

@jhosman jhosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@applecuckoo Thanks so much for opening a PR! #20508 has already been fixed, so I deleted those changes. I'll get your typo fix merged right after I update the branch and tests are passing. Thanks again for your contribution!

@jhosman jhosman added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Sep 22, 2022
@jhosman jhosman enabled auto-merge (squash) September 22, 2022 21:54
@jhosman jhosman merged commit 91a907e into github:main Sep 22, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Starr79
Copy link

Starr79 commented Feb 23, 2023

That was along Journey 🌻✨️🍃

@1054074339

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

content error in shell example for GPG signing articles

5 participants