test: fix test-repl not validating leaked globals properly
#44640
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast-track has been requested by @aduh95. Please |
panva
approved these changes
Sep 14, 2022
MoLow
approved these changes
Sep 14, 2022
|
Landed in 5a40d2e |
29 tasks
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
PR-URL: nodejs#44640 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This was referenced Sep 16, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44640 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44640 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44640 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is needed for #42083, since it's not a semver-major change I thought it would be a good idea to land it in its own PR.