ReDoS: convert RelevantState to a class in the PrefixConstruction module#10285
Merged
erik-krogh merged 4 commits intogithub:mainfrom Sep 12, 2022
Merged
ReDoS: convert RelevantState to a class in the PrefixConstruction module#10285erik-krogh merged 4 commits intogithub:mainfrom
erik-krogh merged 4 commits intogithub:mainfrom
Conversation
aibaars
reviewed
Sep 5, 2022
Contributor
aibaars
left a comment
There was a problem hiding this comment.
Looks good to me. One suggestion.
Co-authored-by: Arthur Baars <aibaars@github.com>
yoff
previously approved these changes
Sep 5, 2022
Contributor
yoff
left a comment
There was a problem hiding this comment.
Sweet, this cleans up nicely :-)
| /** A state within a regular expression that contains a candidate state. */ | ||
| class RelevantState instanceof State { | ||
| RelevantState() { | ||
| exists(State s | isCandidate(s) | getRoot(s.getRepr()) = getRoot(this.getRepr())) |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
| /** A state within a regular expression that contains a candidate state. */ | ||
| class RelevantState instanceof State { | ||
| RelevantState() { | ||
| exists(State s | isCandidate(s) | getRoot(s.getRepr()) = getRoot(this.getRepr())) |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
| /** A state within a regular expression that contains a candidate state. */ | ||
| class RelevantState instanceof State { | ||
| RelevantState() { | ||
| exists(State s | isCandidate(s) | getRoot(s.getRepr()) = getRoot(this.getRepr())) |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
| /** A state within a regular expression that contains a candidate state. */ | ||
| class RelevantState instanceof State { | ||
| RelevantState() { | ||
| exists(State s | isCandidate(s) | getRoot(s.getRepr()) = getRoot(this.getRepr())) |
Check warning
Code scanning / CodeQL
QL-for-QL encountered an internal consistency error
Contributor
Author
|
The QL-for-QL warnings can be ignored, they should be fixed by this PR: #10250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just learned that
class X instanceof Y {inside a parameterized module is allowed.So now I'm using it.
Evaluations were uneventful: Ruby, Java, Python, JavaScript.