Merged
Conversation
Contributor
|
According to #7613, I think the Java queries should have the Also, I think this needs a |
… with missing security-severity tags
atorralba
reviewed
Aug 29, 2022
| * @kind problem | ||
| * @problem.severity error | ||
| * @security-severity 5.8 |
Contributor
There was a problem hiding this comment.
I think the intention here was to remove the line below instead.
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled upon a query that had a missing
@tag security.So I took a look at the results of
ql/missing-security-metadata, and added the missing tags were I could.There still some queries with missing @security-severity, but they are also not tagged with any CWEs, so I'm not sure what to set the value to.